squid: cap inherited file descriptor limit - #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Squid can inherit an unexpectedly large
RLIMIT_NOFILEwhen it is launched in an ApplecontainerKubernetes node. Squid then allocates descriptor-indexed state based on that limit and can consume excessive memory, destabilizing the single-node cluster and making the Kubernetes API time out.This PR adds a small entrypoint that caps the inherited soft and hard descriptor limit at
65536before starting Squid.It also removes the unavailable Alpine package pin (
squid=7.5-r0). Current Alpine repositories provide Squid7.6-r0; the entrypoint workaround is therefore usable with the current package while squid-cache/squid#2483 is pending.Changes
squid/entrypoint.sh.ulimit -n 65536beforeexec squid.apk add --no-cache squid.Validation
Tested on an ARM64 Apple
containerKubernetes cluster:The unmodified image reproduced the failure: a minimal Squid Deployment caused Kubernetes API requests to time out shortly after startup.
The image built from this branch stayed
1/1 Runningacross repeated readiness checks, with the Kubernetes API/readyzremainingok.In the full try-playwright deployment, Squid rolled out successfully and
/proc/1/limitsreported:JavaScript Playwright API tests passed against the deployed stack.
This is intentionally a distribution-level workaround until the upstream Squid fix is available.