fixed crashpad build on Windows with C++20

[igorkorsukov]

Summary by CodeRabbit

• Bug Fixes

  • Improved error message logging consistency for Windows file paths in crash report handling and diagnostics.

• Refactor

  • Removed unused testing utilities and updated internal allocation method signatures for API consistency.

[coderabbitai]

Warning

Rate limit exceeded

@igorkorsukov has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 41 minutes and 37 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 94de5a3b-bd3e-4ab5-a374-1fba7a7877ef

📥 Commits

Reviewing files that changed from the base of the PR and between ae5dda0 and 7b36242.

📒 Files selected for processing (4)

• framework/diagnostics/thirdparty/google_crashpad_client/client/crash_report_database_win.cc
• framework/diagnostics/thirdparty/google_crashpad_client/third_party/mini_chromium/mini_chromium/base/files/file_path.cc
• framework/diagnostics/thirdparty/google_crashpad_client/third_party/mini_chromium/mini_chromium/base/files/file_path.h
• framework/diagnostics/thirdparty/google_crashpad_client/util/stdlib/aligned_allocator.h

📝 Walkthrough

Walkthrough

This PR contains three independent updates to the bundled Crashpad diagnostics library. Windows error logging is updated to consistently convert wide-character file paths to UTF-8 for readable error messages. A GoogleTest PrintTo helper function for FilePath is disabled across both header and implementation files. Finally, the AlignedAllocator allocate method signature is modernized to use const void* for the hint parameter with nullptr as the default value.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided; all required template sections are missing or incomplete.	Add a description explaining the issue resolved, reference the GitHub issue number, confirm checklist items, and document the motivation for these changes.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main purpose of the changeset: fixing crashpad build compatibility with C++20 on Windows.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 523aef8e-a717-44fe-976f-d17b158b0920

📥 Commits

Reviewing files that changed from the base of the PR and between 02c32b0 and ae5dda0.

📒 Files selected for processing (4)

• framework/diagnostics/thirdparty/google_crashpad_client/client/crash_report_database_win.cc
• framework/diagnostics/thirdparty/google_crashpad_client/third_party/mini_chromium/mini_chromium/base/files/file_path.cc
• framework/diagnostics/thirdparty/google_crashpad_client/third_party/mini_chromium/mini_chromium/base/files/file_path.h
• framework/diagnostics/thirdparty/google_crashpad_client/util/stdlib/aligned_allocator.h