Skip to content

Add StyledPopupLoader and PopupButton#40

Open
RomanPudashkin wants to merge 2 commits into
musescore:mainfrom
RomanPudashkin:styled_popup_loader
Open

Add StyledPopupLoader and PopupButton#40
RomanPudashkin wants to merge 2 commits into
musescore:mainfrom
RomanPudashkin:styled_popup_loader

Conversation

@RomanPudashkin
Copy link
Copy Markdown
Contributor

@RomanPudashkin RomanPudashkin commented May 19, 2026

Summary by CodeRabbit

Release Notes

  • New Features
    • PopupButton: New button component with integrated popup display and state management capabilities
    • StyledPopupLoader: New component for managing popup lifecycle, state tracking, and control operations

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Review Change Stack

Warning

Rate limit exceeded

@RomanPudashkin has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 44 minutes and 15 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 16120082-5e86-4218-a5ba-14501184e92f

📥 Commits

Reviewing files that changed from the base of the PR and between 98ee69c and 897af78.

📒 Files selected for processing (3)
  • framework/uicomponents/qml/Muse/UiComponents/CMakeLists.txt
  • framework/uicomponents/qml/Muse/UiComponents/PopupButton.qml
  • framework/uicomponents/qml/Muse/UiComponents/StyledPopupLoader.qml
📝 Walkthrough

Walkthrough

This pull request adds two QML components and registers them in the module. StyledPopupLoader is a Loader-based component that manages a StyledPopupView instance, exposing popup, popupAnchorItem, readonly isOpened, opened/closed signals, and open()/toggleOpened()/close() APIs with deferred load/unload logic. PopupButton wraps a FlatButton and a StyledPopupLoader, exposing aliases for anchor, content, and open state, forwarding opened/closed signals, toggling the popup on click, and exposing close().

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is empty; no description was provided by the author despite the template requiring motivation, implementation details, and confirmation of code quality checks. Add a description explaining the purpose and motivation for these new components, confirm testing and code quality checks, and complete the required checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title 'Add StyledPopupLoader and PopupButton' directly and concisely describes the main changes: two new QML components are being added to the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c284fbd6-a281-49d7-b47c-7ed18dc628aa

📥 Commits

Reviewing files that changed from the base of the PR and between 02c32b0 and c7e8671.

📒 Files selected for processing (3)
  • framework/uicomponents/qml/Muse/UiComponents/CMakeLists.txt
  • framework/uicomponents/qml/Muse/UiComponents/PopupButton.qml
  • framework/uicomponents/qml/Muse/UiComponents/StyledPopupLoader.qml

Comment thread framework/uicomponents/qml/Muse/UiComponents/StyledPopupLoader.qml
@RomanPudashkin RomanPudashkin force-pushed the styled_popup_loader branch 2 times, most recently from ac10cd9 to 98ee69c Compare May 19, 2026 13:41
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@framework/uicomponents/qml/Muse/UiComponents/StyledPopupLoader.qml`:
- Around line 82-94: close() and toggleOpened() currently ignore pendingOpen so
a pending load can still open the popup in onLoaded; update close() and
toggleOpened() to cancel pendingOpen (and any associated load callback) and
ensure onLoaded checks that pendingOpen is still true before opening.
Specifically, in the functions referenced (toggleOpened(), close(), open(),
onLoaded(), and the pendingOpen flag), clear/reset pendingOpen when canceling,
abort or remove any pending load callback, and make onLoaded guard opening by
testing pendingOpen/isOpened so a canceled open no longer opens the popup.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 876682b0-0215-4ff4-a6d8-9a9167ce2b64

📥 Commits

Reviewing files that changed from the base of the PR and between c7e8671 and 98ee69c.

📒 Files selected for processing (3)
  • framework/uicomponents/qml/Muse/UiComponents/CMakeLists.txt
  • framework/uicomponents/qml/Muse/UiComponents/PopupButton.qml
  • framework/uicomponents/qml/Muse/UiComponents/StyledPopupLoader.qml

Comment thread framework/uicomponents/qml/Muse/UiComponents/StyledPopupLoader.qml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant