Add options when fetching all transactions on an account.#2
Open
andrewheald wants to merge 1 commit intomurraysum:masterfrom
Open
Add options when fetching all transactions on an account.#2andrewheald wants to merge 1 commit intomurraysum:masterfrom
andrewheald wants to merge 1 commit intomurraysum:masterfrom
Conversation
Owner
|
Hey @andrewheald Thanks for pointing out this missing functionality. I think I would agree that adding a second argument as a hash is the best way to support retrieving the merchant details for a transaction. However, I am unsure whether I think a better approach for callers would be: Monzo::Transaction.all('acc_xxxxxxxxxxxxx', {expand: 'merchant'})Then the square brackets can be added in the implementation. What do you think? 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Murray. Thanks for the gem. I've raised this tiny PR to add the ability to get all of the merchant details for all of the transactions in one go, like this:
Monzo::Transaction.all('acc_xxxxxxxxxxxxx', {'expand[]': 'merchant'})Thanks,
Andrew.