Fix unbindKey removing every script bind on the key - #5324
Open
Flashmyname wants to merge 1 commit into
Open
Conversation
Only drop the core bind that dispatches the script binds once no script bind is left on that key and state, and return false when nothing was unbound. Fixes multitheftauto#497.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #497.
All script binds on a key go through one shared core bind, and
unbindKeyremoved that shared bind whenever the script side found nothing to remove. So unbinding a function twice, or one that was never bound, silenced every other handler on that key in every resource. It now only goes once no script bind is left, and returnsfalsewhen nothing was removed.Tested with two resources bound to the same key: the other handlers survive, and the second unbind returns
falseinstead of killing both.