Fix remote melee strafing and special-attack sync - #5319
Open
Dryxio wants to merge 2 commits into
Open
Conversation
Preserve melee aim/fire inputs in puresync because fight tasks do not use TASK_SIMPLE_USE_GUN. Apply the existing fight-strafing behavior to all melee weapons instead of restricting it to the unarmed slot. Keep the observer camera front vector from overwriting remote fight heading. Consume the special-attack edge after a simulation step so one held input cannot repeatedly queue attacks between incoming packets. Port the fix from Neon c3b90c264 to upstream master. Use the checked hook installation convention and omit flag preservation: the continuations do not consume integer flags before the epilogue overwrites them. The instrumented Neon version was tested with two clients. Six local F presses produced six single-frame remote edges, and 53 sampled stationary special-attack frames showed no native heading drift. Final upstream runtime testing and before/after recordings are still pending. The upstream build was stopped at the user's request; no completed build is claimed. Formatting and git diff --check passed. Related to multitheftauto#630. Reported in Dryxio/mtasa-neon#102.
FileEX
requested changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes remote players losing the melee strafing animation and shaking during special attacks (aim + F by default).
Before :
strafe2_10mb.mp4
After :
strafe1_10mb.mp4
Motivation
Related to #630 (old bug yes)
Test plan
aim + F
hold aim and left/right to strafe in fight mode
Checklist