Improve resource file checksum performance - #5311
Open
MohabCodeX wants to merge 2 commits into
Open
Conversation
FileEX
requested changes
Sep 4, 2026
|
|
||
| if (pResourceFile->GetLastChecksum() != checksum) | ||
| return true; | ||
| if (!ec && currentWriteTime == pResourceFile->GetLastWriteTime() && currentFileSize == pResourceFile->GetLastFileSize()) |
Member
There was a problem hiding this comment.
Sets a std::error_code& parameter to the OS API error code if an OS API call fails, and executes ec.clear() if no errors occur.
Functions from the std::filesystem library that take a std::error_code& overwrite its state. If the first function (last_write_time) reports an error, but the second one (file_size) succeeds, the latter will clear ec to the success state (ec.clear()). As a result, the if (!ec) check will ignore the fact that the first operation failed.
Additionally, I think it would be worth adding some logging when an error occurs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5286
Optimizes resource loading and client join scaling for resources with large file sets
CDownloadableResource): Defer checksum calculation fordownload="false"files until requested, eliminating the 5-second join freeze and "Network Trouble" dialog.CResource): Replace linearmeta.xmlparsing with hash sets to prevent server startup stalls.download="false"files to the server HTTP cache.Testing