Increase settings window size to fix clipped content with non-English languages#5064
Open
DateFTP wants to merge 6 commits into
Open
Increase settings window size to fix clipped content with non-English languages#5064DateFTP wants to merge 6 commits into
DateFTP wants to merge 6 commits into
Conversation
Increase the settings window content size from 680x480 to 720x520 to prevent content clipping in the Advanced tab when using non-English languages with longer translated labels.
- Compute fComboWidth dynamically based on remaining tab panel width instead of hardcoded 170px, clamped between 100-400px - Fix description label width to use tabPanelSize.fX instead of hardcoded 500px - Fix 'Check for update now' button position to clamp within tab bounds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Increases the settings window content size from 680x480 to 720x520 to prevent content clipping, particularly affecting the Advanced tab when using non-English languages.
Problem
The Advanced tab uses IndentX computed from the max text extent of translated labels. With non-English languages (e.g. Russian, German), translated strings are significantly longer, causing combo boxes and other content to overflow past the right edge of the tab panel.
Changes
The window remains centered on screen (position is computed as (resolution - windowSize) / 2).
Testing
Checklist