dev: Update module github.com/google/go-github/v89 to v91 - #203
dev: Update module github.com/google/go-github/v89 to v91#203mm-renovate-bot[bot] wants to merge 1 commit into
Conversation
ℹ️ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe module’s Go requirement changed from 1.25.0 to 1.26.0. The Suggested reviewers: Merge Risk: ⚪ Minimal · up to This updates the GitHub client dependency to v91 and raises the required Go version to 1.26 without changing application logic. No merge-blocking risk is currently identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
Comment |
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "time" | ||
|
|
||
| "github.com/google/go-github/v89/github" | ||
| "github.com/google/go-github/v91/github" |
There was a problem hiding this comment.
When this package compiles against go-github v91, the stale-review dismissal and issue-comment calls still use request types, parameter forms, and methods removed by v90 or v91, causing application builds, tests, and releases to fail.
Prompt To Fix With AI
This is a comment left during a code review.
Path: internal/github/gh.go
Line: 13
Comment:
**V91 breaks existing API calls**
When this package compiles against go-github v91, the stale-review dismissal and issue-comment calls still use request types, parameter forms, and methods removed by v90 or v91, causing application builds, tests, and releases to fail.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This PR contains the following updates:
v89.0.0→v91.0.0Release Notes
google/go-github (github.com/google/go-github/v89)
v91.0.0Compare Source
This release contains the following breaking API changes:
EditCommenttoUpdateCommentonPullRequestsService, split review comment request bodies, and pass by value (#4493)BREAKING CHANGE:
PullRequestsService.CreateCommentnow takesCreatePullRequestCommentRequestby value;PullRequestsService.EditCommentis nowUpdateCommentand takesUpdatePullRequestCommentRequestby value.Keyrequest bodies intoCreateDeployKeyRequest,CreateUserKeyRequestandCreateSSHSigningKeyRequestand pass by value (#4477)BREAKING CHANGE:
RepositoriesService.CreateKey,UsersService.CreateKeyandUsersService.CreateSSHSigningKeynow takeCreateDeployKeyRequest,CreateUserKeyRequestandCreateSSHSigningKeyRequestby value.PendingDeploymentsRequestandReviewCustomDeploymentProtectionRuleRequestby value (#4475)BREAKING CHANGE:
ActionsService.PendingDeploymentsandActionsService.ReviewCustomDeploymentProtectionRulenow takePendingDeploymentsRequestandReviewCustomDeploymentProtectionRuleRequestby value.EditCommenttoUpdateCommentonIssuesService, pass a newIssueCommentRequestby value, and add missingIssueCommentfields (#4444)BREAKING CHANGE:
IssuesService.CreateCommentnow takesIssueCommentRequestby value;IssuesService.EditCommentis nowUpdateCommentand takesIssueCommentRequestby value.ImpersonateUserOptionstoCreateUserImpersonationRequestand pass by value (#4462)BREAKING CHANGE:
AdminService.CreateUserImpersonationnow takesCreateUserImpersonationRequestby value instead of*ImpersonateUserOptions.BREAKING CHANGE:
CreateTeamandUpdateTeamBy*now take new body params by value.EditMilestonetoUpdateMilestone, splitMilestonerequest bodies intoCreateMilestoneRequestandUpdateMilestoneRequest, and pass by value (#4438)BREAKING CHANGE:
IssuesService.CreateMilestonenow takes a newCreateMilestoneRequestby value;IssuesService.EditMilestoneis nowUpdateMilestoneand takes a newUpdateMilestoneRequestby value.UpdatePreReceiveHookrequest body by value via newUpdatePreReceiveHookRequest(#4434)BREAKING CHANGE:
RepositoriesService.UpdatePreReceiveHooknow takes a newUpdatePreReceiveHookRequestby value instead of*PreReceiveHook.UsersService.EdittoUpdate, introduceUserUpdateRequest, and pass request by value (#4433)BREAKING CHANGE:
UsersService.Editis nowUpdateand uses a newUserUpdateRequestbody value.UpdateUserLDAPMappingRequestandUpdateTeamLDAPMappingRequest(#4432)BREAKING CHANGE:
AdminService.UpdateUserLDAPMappingandUpdateTeamLDAPMappingnow takeUpdateUserLDAPMappingRequestandUpdateTeamLDAPMappingRequest(with non-pointerLDAPDN) by value....and the following additional changes:
MergeAsyncandGetMergeAsyncResultsupport (#4491)Client.Doresponse decoding with a buffer pool (#4494)paramcheckallowlist entries (#4476)publictoggle on repository visibility rules (#4455)Fprintfinfmtpercentvlinter check (#4443)Userentry from the paramcheck allowlist (#4437)openapi_operations.yaml(#4430)v90.0.0Compare Source
This release contains the following breaking API changes:
UpdateConnectedExternalGrouprequest body by value via newUpdateConnectedExternalGroupRequest(#4425)BREAKING CHANGE:
TeamsService.UpdateConnectedExternalGroupnow takesUpdateConnectedExternalGroupRequest(with non-pointerGroupID) by value.PullRequestReviewDismissalRequesttoPullRequestDismissReviewRequest, addPullRequestSubmitReviewRequest, and pass review request bodies by value (#4406)BREAKING CHANGE:
PullRequestReviewDismissalRequestis nowPullRequestDismissReviewRequestwith non-pointerMessageandPullRequestsService.DismissReviewtakes it by value;PullRequestsService.SubmitReviewnow takes a newPullRequestSubmitReviewRequest.CreateOrUpdateCustomRepoRoleOptionsintoCreateCustomRepoRoleRequestandUpdateCustomRepoRoleRequestand pass by value (#4401)BREAKING CHANGE:
CreateOrUpdateCustomRepoRoleOptionsis split intoCreateCustomRepoRoleRequest(with non-pointerNameandBaseRole) andUpdateCustomRepoRoleRequest;OrganizationsService.CreateCustomRepoRoleandUpdateCustomRepoRolenow take these request types by value.EditLabeltoUpdateLabel, SplitLabelintoCreateLabelRequest&UpdateLabelRequestand pass by value (#4400)BREAKING CHANGE:
IssuesService.CreateLabelnow takesCreateLabelRequestby value (with required non-pointerName);IssuesService.EditLabelrenamed toUpdateLabel, taking anUpdateLabelRequestby value.AutolinkOptionstoCreateAutolinkRequest,AddAutolinktoCreateAutolink, and pass the body by value (#4399)BREAKING CHANGE:
AutolinkOptionsis nowCreateAutolinkRequestwith non-pointerKeyPrefixandURLTemplate;RepositoriesService.AddAutolinkis nowCreateAutolinkand passesbodyby value.IssueRequestintoCreateIssueRequest&UpdateIssueRequestand pass by value (#4396)BREAKING CHANGE:
IssueService.Editis renamed toIssueService.Update.NewPullRequesttoCreatePullRequestand pass it by value (#4395)BREAKING CHANGE:
NewPullRequestis renamed toCreatePullRequest,PullRequests.Createnow takes it by value, andCreatePullRequest.HeadandCreatePullRequest.Baseare nowstring.SarifAnalysisby value (#4394)BREAKING CHANGE:
CodeScanningService.UploadSarifnow takesbodyby value and its required fields are no longer pointers.CreateDeploymentBranchPolicyRequestandUpdateDeploymentBranchPolicyRequestby value (#4382)BREAKING CHANGE:
RepositoriesService.CreateDeploymentBranchPolicyandUpdateDeploymentBranchPolicynow takebodyby value and the requiredNamefield is of typestring.TemplateRepoRequestby value inRepositories.CreateFromTemplate(#4378)BREAKING CHANGE:
RepositoriesService.CreateFromTemplatenow passesbodyby value andNameis now required and passed by value.RepositoryMergeRequestandRepoMergeUpstreamRequestby value (#4372)BREAKING CHANGE:
RepositoriesService.MergeandRepositoriesService.MergeUpstreamnow passbodyby value and required struct fields are now values.BREAKING CHANGE:
DependabotServicemethods involving secrets have new params and return values....and the following additional changes:
MetaService.ListAPIVersions(#4422)DeleteCodeQLDatabasefor code scanning (#4421)Stackfield toPullRequestfor stacked pull requests (#4423)search_typesupport to issue search (#4414)Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.