deps: move to rustls 0.23 - #216
Merged
Merged
Conversation
rustls 0.22 caps rustls-webpki at 0.102, which no longer receives fixes. Four advisories (GHSA-82j2-j2ch-gfr8, GHSA-pwjx-qhcg-rvj4, GHSA-xgp8-3hg3-c2mh, GHSA-965h-392x-2mh5) only landed in 0.103, so every consumer of sandlock-core inherits them for as long as the pin stays. The pin was inherited from hudsucker, which is gone. rustls 0.23 selects a crypto provider at runtime and panics when more than one is compiled in and none is installed process-wide. Pass the ring provider explicitly at each builder so a downstream crate that also enables aws-lc-rs does not trip that, and keep aws-lc-rs out of our own tree so the build needs no cmake or C toolchain. Fixes #214 Signed-off-by: Cong Wang <cwang@multikernel.io>
congwang-mk
force-pushed
the
rustls-0.23
branch
from
September 10, 2026 00:21
c1678de to
7aafb44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps rustls 0.22 to 0.23 (with tokio-rustls 0.26 and hyper-rustls 0.27) so rustls-webpki can move to the 0.103 line. The lockfile now carries rustls-webpki 0.103.15, which covers all four advisories from #214:
The 0.22 pin was inherited from hudsucker, which was dropped earlier, so nothing else held it.
Provider handling
rustls 0.23 picks a crypto provider at runtime and panics if more than one is compiled in with none installed process-wide. The three builder sites (server config, upstream connector, test client) now pass the ring provider explicitly, so a downstream crate that also enables aws-lc-rs is unaffected. Our own features keep aws-lc-rs out of the tree, so the build still needs no cmake or C toolchain.
Test plan
cargo build --workspacecargo test -p sandlock-core --lib transparent_proxy(8 passed)cargo test -p sandlock-core --test integration http(16 passed, covers HTTP ACL, HTTPS MITM, credential injection, CA injection)Fixes #214