Repository navigation
fix(ci): repair master failures in CLI bind test, addons UI build and e2e - #12876
Merged
Merged
Conversation
2001:db8::/32 is the IPv6 documentation prefix and is now classed as non-public, so the bind is trusted and the spec failed. Use a public address from 2606:4700:4700::/48 instead.
…llFlow.jsx installFlow.js and InstallFlow.jsx differ only by case. On a case-insensitive filesystem the bundler can resolve `import FlowStatus from './InstallFlow'` to the .js module, which has no default export, and the macOS build fails with MISSING_EXPORT. Rename the module to installAndTurnOn.js, after its main export, and update its two importers. No code changes. Assisted-by: Claude Code:claude-sonnet-5-5
The clearer empty states for a stopped add-on dropped the Reload button from the unavailable page, so a user who turned the add-on back on had no way to mount it again without leaving the page. Render the button in the actions of the off state, next to Turn on.
The remembered voices link now opens the page of the Voice add-on, which the core build no longer draws. Install the built Voice bundle next to Studio, as the other specs do for their add-ons, and build it in the global setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three failures on
masterthat were red for PRs too.core/cli): the "rejects public IPv6" spec used2001:db8::1, the IPv6 documentation prefix. Since [httpclient] validate redirect targets and pin dialed addresses for user URLs #12853 that prefix is classed as non-public, so the bind is correctly trusted and the spec failed. The spec now uses a globally routable address. The policy code is unchanged.installFlow.jsandInstallFlow.jsxdiffered only by case. On a case-insensitive filesystem,import ... from './InstallFlow'can resolve to the file without a default export. The module is renamed toinstallAndTurnOn.js(a pure rename) and its two importers are updated.Verification
go test ./core/cli/: 106 of 106 specs pass.npm run buildand the unit tests pass.addons-shellanddiarization-profilespass (15/15).addon-navigation,studio-addonsandlegacy-redirectspass (114/114).npm run lintreports two errors ine2e/coverage-fixtures.js, which this PR does not touch.Not verified: the combined branch was not re-run as a whole, and the macOS build was not run here.
🤖 Generated with Claude Code