Repository navigation
Conversation
Collaborator
|
@mudler source-review sign-off at The GPU branch now reports system RAM while preserving the VRAM aggregate used by the reclaimer. I pushed the missing docs update as Validation: |
Fixes mudler#12834 Assisted-by: Claude:claude-opus-5-5 Signed-off-by: berce <75228263+bercedev@users.noreply.github.com>
bercedev
force-pushed
the
fix/resources-ram-with-gpu
branch
from
October 23, 2026 18:32
d1d7d5c to
01fcd6b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a GPU was detected,
GetResourceInfo()returnedRAM: nil, so/api/resourcesalways had"ram": nullon GPU machines. System RAM was only read in the no-GPU fallback. The UI already expects both:HomeMemoryStripdraws a RAM bar forisGpu && host.ram, and the model fit and placement code readresources.ramfor CPU offload.The GPU branch now also calls
GetSystemRAMInfo()and fillsRAM.TypeandAggregatestay on the VRAM numbers, so the memory reclaimer (GetResourceAggregateInfo) behaves as before.This PR fixes #12834
Notes for Reviewers
go vet ./pkg/xsysinfo/andgo test ./pkg/xsysinfo/pass, and gofmt is clean. I didn't add a test: GPU detection has no seam to stub in this package. I also didn't run it on a GPU machine.AI disclosure: written with Claude Code (
Assisted-bytrailer on the commit). The commit has noSigned-off-by, since CONTRIBUTING.md leaves that to the human submitter.Signed commits