Repository navigation
fix(ui): repair model layout and CI assertions - #12587
Merged
Merged
Conversation
Let model descriptions wrap without losing the install action offscreen. Give page table rules precedence over the shared table styles. Separate background facet probes from navigation assertions and wait for asynchronous size sorting and masonry layout. Fix the chat fixture clock so runs near midnight keep the expected conversation groups and order. Assisted-by: Codex:gpt-6
Playwright joins adjacent table-cell text. A llama-cpp backend followed by 99 requests then matches p99, although no percentile is shown. Require word boundaries while keeping the absence assertion. Assisted-by: Codex:gpt-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the UI E2E failures on master after #12526, including run 37836549755.
The model Variants table puts Install beyond a phone viewport. Give its wrapping rules precedence over the shared table CSS and limit the build description width on phones. Update the model documentation.
Make the related UI assertions follow asynchronous state: distinguish facet-count probes from gallery navigation, await cleanup size ordering and masonry initialization, and use a fixed date for chat-history fixtures. Match complete percentile labels so adjacent cells containing
llama-cppand99requests do not produce a falsep99match.Notes for Reviewers
Validated locally with the production V8-coverage bundle and Chromium, using the existing Playwright API mocks through a temporary static server:
npm run lint:inline-stylesandgit diff --checkpass.No coverage baseline or tolerance changed. Full GitHub CI remains to run. The same shared fixes were applied to the affected bot PRs #12319, #12307, #12145, and #12051; #12145 also needed its editor selector updated.
Signed commits
Assisted-by: Codex:gpt-6.docs/content/.