Skip to content

fix(vllm): structured outputs silently ignored on vLLM >= 0.23 (GuidedDecodingParams removed) #10343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pos-ei-don wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −4
Open

fix(vllm): structured outputs silently ignored on vLLM >= 0.23 (GuidedDecodingParams removed) #10343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions backend/python/vllm/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,10 @@
except ImportError:
HAS_REASONING_PARSERS = False

# vLLM >= 0.23 renamed GuidedDecodingParams -> StructuredOutputsParams and the
# SamplingParams field guided_decoding -> structured_outputs.
try:
from vllm.sampling_params import GuidedDecodingParams
from vllm.sampling_params import StructuredOutputsParams
HAS_GUIDED_DECODING = True
except ImportError:
HAS_GUIDED_DECODING = False
Expand Down Expand Up @@ -536,13 +538,13 @@ async def _predict(self, request, context, streaming=False):
if value not in (None, 0, [], False):
setattr(sampling_params, param_field, value)

# Guided decoding: use Grammar field to pass JSON schema or BNF
# Structured-output decoding: use Grammar field to pass JSON schema or BNF
if HAS_GUIDED_DECODING and request.Grammar:
try:
json.loads(request.Grammar) # valid JSON = JSON schema
sampling_params.guided_decoding = GuidedDecodingParams(json=request.Grammar)
sampling_params.structured_outputs = StructuredOutputsParams(json=request.Grammar)
except json.JSONDecodeError:
sampling_params.guided_decoding = GuidedDecodingParams(grammar=request.Grammar)
sampling_params.structured_outputs = StructuredOutputsParams(grammar=request.Grammar)

# Extract image paths and process images
prompt = request.Prompt
Expand Down
Loading