Open
Conversation
a81f6d3 to
a23d7fc
Compare
…at could be cached
a23d7fc to
0b3de0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a requests hits the cache, the cache might have an instant cached response.
When the cache gets 2 requests simultaneously with the same key, so the second should get a cached request, yet it doesn't because the cache is only updated after the request is finished.
What happens:
Expected:
What happens:
This pull request alleviates this by creating a
Coalescerduring the request on which incoming requests can attach and get the same response as the starting request.