Fix verification result on timestamp failure - #510
Merged
mtrojnar merged 1 commit intoSep 30, 2026
Merged
Conversation
Propagate timestamp verification failures to the overall verification result and add regression tests, while preserving -ignore-timestamp behavior. Signed-off-by: olszomal <Malgorzata.Olszowka@stunnel.org>
Owner
|
It's an interesting edge case: the current behavior seems technically correct, while the new behavior seems desirable at least for validating our own signatures. What does signtool do in this case? |
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related Issue
Fixes #509
Current Behavior
A valid Authenticode signature may still verify successfully while the signing certificate is currently valid, even if timestamp verification fails. The timestamp is primarily used to establish that the signature existed while the signing certificate was valid, allowing it to remain verifiable after the certificate expires.
New Behavior
Verification fails when timestamp verification fails, unless timestamp verification is explicitly disabled with
-ignore-timestamp.Scope of Changes
-ignore-timestamp.Testing
Additional Notes
This change affects only the overall verification result; the Authenticode signature and timestamp verification results are still reported separately.
License Declaration