fix: support schemas defined using allOf#93
Open
jordan-burnett wants to merge 1 commit intomswjs:mainfrom
Open
fix: support schemas defined using allOf#93jordan-burnett wants to merge 1 commit intomswjs:mainfrom
allOf#93jordan-burnett wants to merge 1 commit intomswjs:mainfrom
Conversation
Member
|
Hi, @jordan-burnett. Thank you for suggesting this, it's definitely a missing piece. Do you think this fix makes more sense in https://github.com/yellow-ticket/seed-json-schema? There's also an open issues for |
Author
|
Hey @kettanaito. You're right, it probably does makes more sense in there. Think I understand a bit better now how the two libraries interact. I'll have a go at porting this over when I get a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenAPI spec supports combining schemas with keywords like
allOforoneOfSchemas that use one of these keywords currently produce empty response bodies due to
seedSchemabeing passed the wrapper rather than the nested schemas.I've resolved it for
allOfby adding an extra step that merges any nested schemas so the seed function only sees the final schema and produces an output that matches all of them.Supporting the other keywords would require making a decision about which schema to use (perhaps just choosing the first one would be reasonable?). For now I've only implemented for
allOfto keep things simple.