Fix backup scheduler, replace browse with upload, UI improvements #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix scheduled backup using root crontab instead of Unraid cron helper - Replace 'Browse for Archive' with file upload via FormData/AJAX - Validate uploaded archive type, duplicates, and destination writability - Show stack names in restore confirmation dialog instead of count - Replace save-settings popup (swal) with inline status banner - Restrict help cursor to settings that have help text - Simplify cron log output to single completion line - Match restore status message width to backup tables - Standardize backup/restore log format with category tags
Author
|
@mstrhakr we should try to figure out how to get this on Unraid App Store after this one (or even an update on Reddit). All critical issues are resolved. Having more users would help identify further bugs. |
- Change default shell from /bin/sh to /bin/bash across all console entry points - Add server-side fallback: check if bash exists in container via 'which', fall back to sh if not - Affects: exec.php, compose_util.php, compose_manager_main.php, dashboard page
Owner
I've found the official source on this finally. I will start working on this. |
The addStack handler returned the full filesystem path as 'project' (e.g. /boot/.../projects/My_Stack) instead of just the directory name (e.g. My_Stack). When the editor modal later sent this as 'script' to save endpoints, the server constructed compose_root + script which doubled the path, causing saves to silently fail on newly created stacks. Also fixed 'projectName' to return the user-entered display name instead of the sanitized directory name. Resolves mstrhakr#15
When no description file exists and no label description is set, the stack list was showing 'No description (path)' which pre-populated the description with the filesystem path. Changed to show blank instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
All 233 unit tests pass (433 assertions). Updated \testBrowseArchiveButton\ → \testUploadArchiveButton\ to reflect the upload change.