fix: scope LOGINDISABLED check to plaintext LOGIN branch - #935
Open
EJSRobinson wants to merge 1 commit into
Open
EJSRobinson wants to merge 1 commit into
EJSRobinson wants to merge 1 commit into
Conversation
The LOGINDISABLED guard was an unconditional early return placed above auth mechanism selection, so servers advertising both AUTH=XOAUTH2 and LOGINDISABLED (e.g. Exchange Online) aborted before the XOAUTH2 branch was reached, even with a valid token configured. Move the check inside the user/password branch so it only blocks plaintext LOGIN. Basic auth behaviour and error message are unchanged; the STARTTLS use of LOGINDISABLED is untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LOGINDISABLED guard was an unconditional early return placed above auth mechanism selection, so servers advertising both AUTH=XOAUTH2 and LOGINDISABLED (e.g. Exchange Online) aborted before the XOAUTH2 branch was reached, even with a valid token configured.
Move the check inside the user/password branch so it only blocks plaintext LOGIN. Basic auth behaviour and error message are unchanged; the STARTTLS use of LOGINDISABLED is untouched.