Open
Conversation
Member
|
Thanks for the PR. The spread operator cannot be used for this to be compatible with mPDF in lower versions of PHP. Also, a unit test for the change should be present (which would reveal the incompatibility mentioned). |
Author
|
The test setup seems to be configured only for PHP 5.6 onwards. Argument unpacking was introduced in PHP 5.6, so that should work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the Mpdf Output function to pass along an optional fourth argument to
SetDrawColorandSetFillColor, so that CMYK colors can be used for the QR Code.