-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Add placement event mapping for event attributes #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prestonstarkey
wants to merge
8
commits into
mparticle-integrations:development
Choose a base branch
from
prestonstarkey:feat/LE-add-event-mapping-configuration
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
31b8be7
LE - add placement event mapping rules on attributes
prestonstarkey d4877d7
LE - update to use AttributeSelector
prestonstarkey 34a6d44
LE - update unit tests
prestonstarkey 66792ad
LE - update names
prestonstarkey 114f325
LE - add unit test for missing conditions
prestonstarkey 1a360e7
LE - update condition checks to use isString utility
prestonstarkey 6a0d4e3
LE - add unit tests
prestonstarkey e7c4ee7
LE - remove comment and fix lint
prestonstarkey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider adding some additional test cases to add some potential edge cases. Something like
2 === "2" would likley pass as intended but what if you're testingtrue === 'True'or even"TRUE" === 'True'"`?I think you have some guard clauses that should catch this, but also make sure something like
"0" === "false"or"0" === ""is covered in tests.