Allow initializing WASM contents in Node.js - #532
Open
Hanabi9248 wants to merge 4 commits into
Open
Hanabi9248 wants to merge 4 commits into
Hanabi9248 wants to merge 4 commits into
Conversation
Author
|
Following up on the Node.js bundling case in #527: would supporting explicitly supplied WASM bytes through initialize() fit the API direction? This keeps filesystem loading as the default and tests the bundled case in a fresh process with filesystem loading disabled. I’d appreciate feedback when you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #527.
SourceMapConsumer.initialize()ignores supplied WASM bytes in Node.js, so a bundle still tries to readmappings.wasmnext to the relocated module.Use a supplied
ArrayBufferwhen available, keeping the filesystem loader as the default. The README and API comments now describe this Node.js behavior. Callers must initialize before constructing consumers; an existing WASM instance is not replaced.The regression test starts a fresh process, makes filesystem loading fail, and checks a source position using the real WASM. It fails before this change and passes afterward. Separate tests cover the supplied bytes and default loader.
Tested on Windows with Node.js v24.19.0:
node test/run-tests.js: 193/193 passed.