Bug-1948879: Add links to docs and source in the Banner#995
Draft
moijes12 wants to merge 2 commits intomozilla:mainfrom
Draft
Bug-1948879: Add links to docs and source in the Banner#995moijes12 wants to merge 2 commits intomozilla:mainfrom
moijes12 wants to merge 2 commits intomozilla:mainfrom
Conversation
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Added links to PerfCompare docs and GitHub source in the Banner.
Contributor
Author
|
@kala-moz I did run npm run fix-all and the tests run locally. Is there anything I need to do to fix it? |
Update snapshots
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #995 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 104 104
Lines 3016 3018 +2
Branches 686 686
=======================================
+ Hits 2907 2909 +2
Misses 108 108
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@moijes12 as julien mentioned in the bug, we should wait for padenot to respond with what he expects to see how we should resolve the bug. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added links to docs and source in the Banner by updating
App.tsx.Fixes Bug-1948879