Bug-1999558: Display complete commit message even when newline is absent#1000
Merged
kala-moz merged 4 commits intomozilla:mainfrom Feb 17, 2026
Merged
Bug-1999558: Display complete commit message even when newline is absent#1000kala-moz merged 4 commits intomozilla:mainfrom
kala-moz merged 4 commits intomozilla:mainfrom
Conversation
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1000 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 104 104
Lines 3025 3028 +3
Branches 691 694 +3
=======================================
+ Hits 2918 2921 +3
Misses 106 106
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmierz
reviewed
Feb 11, 2026
Contributor
Author
Contributor
|
@moijes12 Hi Alex, for future PRs, there's no need to @ Dave Hunt . |
kala-moz
requested changes
Feb 13, 2026
Contributor
kala-moz
left a comment
kala-moz
left a comment
There was a problem hiding this comment.
Thanks for your PR. Also, in the future, you can add screenshots to the PR itself vs the bug. Makes it faster to review. Aside from the comment changes, this LGTM.
This change ensures that single line commit messages with absent newlines are displayed correctly. If a newline is present in the message summary, then it is treated as the commit message. If no newline is present in the message summary, then the entire summary is taken as commit message. A new test has been added to verify the change. The snapshots have been regenerated to reflect the changes. @kala-moz @davehunt Fixes [Bug-1999558](https://bugzilla.mozilla.org/show_bug.cgi?id=1999558)
Implement review comment by making the added comment into a multiline comment.
Remove Bug number from comment as suggested in review comment
Fix merge conflicts by rebasing code over latest changes in main.
Contributor
Author
|
@kala-moz Rebased my changes over the latest code in main and fixed the merge conflicts in latest commit |
kala-moz
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
This change ensures that single line commit messages with absent newlines are displayed correctly. If a newline is present in the message summary, then it is treated as the commit message. If no newline is present in the message summary, then the entire summary is taken as commit message.
Testing
A new test has been added to verify the change. The snapshots have been regenerated to reflect the changes.
@kala-moz @davehunt
Fixes Bug-1999558