Include transfers correctly in the "GetOperatorList" message (PR 16588 follow-up)#20734
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20734 +/- ##
=======================================
Coverage 62.76% 62.76%
=======================================
Files 169 169
Lines 119838 119845 +7
=======================================
+ Hits 75211 75225 +14
+ Misses 44627 44620 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…8 follow-up) Currently the transfers aren't actually being used with the "GetOperatorList" message, since the placement of the parameter is wrong; note the method signature: https://github.com/mozilla/pdf.js/blob/909a700afa004167bb05bc3d67ed113e74a71729/src/shared/message_handler.js#L219-L229 This goes back to PR 16588, which added the transfers parameter, and unfortunately we all missed that :-( Simply fixing the parameter isn't enough however, since that broke printing of Stamp-editors (and possibly others). The solution here is to *not* transfer data during printing, given that a single `PrintAnnotationStorage` instance is being used for all pages.
979d37b to
82fc2c9
Compare
|
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4320b18b323fa6c/output.txt |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/89c11748a815dfd/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/4320b18b323fa6c/output.txt Total script time: 60.00 mins |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/89c11748a815dfd/output.txt Total script time: 85.44 mins
Image differences available at: http://54.193.163.58:8877/89c11748a815dfd/reftest-analyzer.html#web=eq.log |
Currently the transfers aren't actually being used with the "GetOperatorList" message, since the placement of the parameter is wrong; note the method signature:
pdf.js/src/shared/message_handler.js
Lines 219 to 229 in 909a700
Simply fixing the parameter isn't enough however, since that broke printing of Stamp-editors (and possibly others). The solution here is to not transfer data during printing, given that a single
PrintAnnotationStorageinstance is being used for all pages.