Skip to content

Convert the data reading in getPdfManager to be asynchronous#20662

Draft
Snuffleupagus wants to merge 1 commit intomozilla:masterfrom
Snuffleupagus:getPdfManager-async-read
Draft

Convert the data reading in getPdfManager to be asynchronous#20662
Snuffleupagus wants to merge 1 commit intomozilla:masterfrom
Snuffleupagus:getPdfManager-async-read

Conversation

@Snuffleupagus
Copy link
Collaborator

This is not only shorter, but (in my opinion) it also simplifies the code.

Note: In order to keep the five different BasePDFStreamReader implementations consistent, we purposely don't re-factor the PDFWorkerStreamReader class to support for await...of iteration.

This is not only shorter, but (in my opinion) it also simplifies the code.

*Note:* In order to keep the *five* different `BasePDFStreamReader` implementations consistent, we purposely don't re-factor the `PDFWorkerStreamReader` class to support `for await...of` iteration.
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 86.79245% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.81%. Comparing base (c574694) to head (3117bc2).

Files with missing lines Patch % Lines
src/core/worker.js 86.79% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20662      +/-   ##
==========================================
+ Coverage   59.79%   59.81%   +0.02%     
==========================================
  Files         169      169              
  Lines       90158    90156       -2     
==========================================
+ Hits        53907    53928      +21     
+ Misses      36251    36228      -23     
Flag Coverage Δ
unittestcli 59.81% <86.79%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments