Repository navigation
Fix SOURCE_DATE_EPOCH tests when the variable is already set - #872
Merged
Merged
Conversation
badboy
approved these changes
Oct 21, 2026
badboy
enabled auto-merge (rebase)
October 21, 2026 11:29
auto-merge was automatically disabled
October 21, 2026 11:33
Rebase failed
test_expire_epoch_can_be_overriden assumed SOURCE_DATE_EPOCH was unset on entry, so it failed in reproducible build environments (such as Nixpkgs or Debian) that export it, typically as some date before the test's 2023-12-31 expiry. Use monkeypatch to clear it first, and to set it in both SOURCE_DATE_EPOCH tests so the environment is restored even if an assertion fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
badboy
force-pushed
the
source-date-epoch-tests
branch
from
October 21, 2026 12:15
9a57d27 to
7a7f20c
Compare
Member
|
Rebased now to fix the merge conflict in the changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_expire_epoch_can_be_overridenassumedSOURCE_DATE_EPOCHwas unset on entry, so it failed in reproducible build environments (such as Nixpkgs or Debian) that export it, typically as some date before the test's 2023-12-31 expiry. Usemonkeypatchto clear it first, and to set it in bothSOURCE_DATE_EPOCHtests so the environment is restored even if an assertion fails.SOURCE_DATE_EPOCHto use as the date to check expiry against #851 (comment).Pull Request checklist
make testruns without emitting any warningsmake lintruns without emitting any errorsCHANGELOG.mdor an explanation of why it does not need one