Skip to content

DENG-9533 - Go server template: support publishing directly to Pub/Sub#821

Merged
akkomar merged 3 commits into
mainfrom
go_direct_pubsub
May 29, 2026
Merged

DENG-9533 - Go server template: support publishing directly to Pub/Sub#821
akkomar merged 3 commits into
mainfrom
go_direct_pubsub

Conversation

@akkomar
Copy link
Copy Markdown
Member

@akkomar akkomar commented Nov 6, 2025

This adds a Go server template for direct-to-Pub/Sub submissions.
For big picture see https://mozilla-hub.atlassian.net/browse/DENG-9533.
This data will be consumed by new Decoder type landed in mozilla/gcp-ingestion#2857.
Next steps after this lands are to test with MARS in stage, iron out wrinkles, and update our documentation.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly

@akkomar akkomar force-pushed the go_direct_pubsub branch from 89619bd to 203b435 Compare May 29, 2026 09:02
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file introduces some duplication with test_go_server.py, but I've put it as separate one to be sure that we're not touching current behavior.

@akkomar akkomar marked this pull request as ready for review May 29, 2026 09:06
@akkomar akkomar requested a review from a team as a code owner May 29, 2026 09:06
@akkomar akkomar requested review from badboy and travis79 and removed request for a team May 29, 2026 09:06
Copy link
Copy Markdown
Member

@badboy badboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc. few comments inline, nothing blocking though.

Comment thread glean_parser/templates/go_server.jinja2 Outdated
Comment thread glean_parser/templates/go_server.jinja2 Outdated
Comment thread glean_parser/go_server.py Outdated
akkomar and others added 2 commits May 29, 2026 12:51
Co-authored-by: Jan-Erik Rediger <jrediger@mozilla.com>
@akkomar akkomar merged commit ec5d546 into main May 29, 2026
8 checks passed
@akkomar akkomar deleted the go_direct_pubsub branch May 29, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants