Skip to content

Bug 2048968 - Add ordering for links and shares - #86

Merged
nathan-barrett merged 1 commit into
mainfrom
bug-2048968-link-ordering
Jul 15, 2026
Merged

Bug 2048968 - Add ordering for links and shares#86
nathan-barrett merged 1 commit into
mainfrom
bug-2048968-link-ordering

Conversation

@nathan-barrett

Copy link
Copy Markdown
Collaborator

Adds a new position property so that shares are listed in the order they were shared

Docs:

@nathan-barrett
nathan-barrett requested a review from a team as a code owner July 7, 2026 14:39

@fterdal fterdal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! It works for me locally, and the position Meta field is cool 😎. The only thing I'd mention is that there's no obvious way to break ties if two links have the same position.

This shouldn't happen in practice going forward, since new link collections will be passed a position determined by the index. But seeded data (or database rows that gets into a weird state for some reason 🤷🏻) might show up in an unpredictable order.

Links don't have a created_at field to break ties either, and I don't think it's worth adding one just for this purpose.

✅ r+ – This is good to go, just mentioning this here in case we care about tie-breaking behavior in the future.

@nathan-barrett

Copy link
Copy Markdown
Collaborator Author

good point! wonder if we'd need tie breaking at any point 🤔

@nathan-barrett
nathan-barrett merged commit b9ae3fa into main Jul 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants