Bug 2050525 - Don't add fetch_link_preview failures to DLQ - #85
Merged
Conversation
…able Add a `dead_letter` opt-out flag to BaseTaskWithRetry and set it to False on fetch_link_preview: the failure is still logged and reaches Sentry via the Celery integration, but no DLQ row is created.
fterdal
changed the title
fterdal
marked this pull request as ready for review
June 25, 2026 18:10
jaredhirsch
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
dead_letteropt-out flag to BaseTaskWithRetry and set it to False on fetch_link_preview: the failure is still logged and reaches Sentry via the Celery integration, but no DLQ row is created.This should cut down on unnecessary DLQ noise. As of right now, 100% of the rows in the DLQ are related to fetch_link_preview (e.g. 403 Forbidden or 402 Payment Required). Since they can't be retried, there's no need to add them to the DLQ.