Skip to content

fix(settings): wrap the scan-QR help link inside the phone frame - #21189

Draft
dschom wants to merge 1 commit into
mainfrom
FXA-14486
Draft

fix(settings): wrap the scan-QR help link inside the phone frame#21189
dschom wants to merge 1 commit into
mainfrom
FXA-14486

Conversation

@dschom

@dschom dschom commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Because

  • On the new pairing scan-QR page, long translations of the "Get help scanning" link (French, for one) overflow the phone graphic frame.

This pull request

  • Caps the help link's width so long strings wrap onto a second line inside the phone screen.

Issue that this pull request solves

Closes: FXA-14486

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

  • Key files/areas to focus on:
  • Suggested review order:
  • Risky or complex parts:

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

  • The overlay does not grow the card, so a translation needing a third line would still clip below the artwork. The French string fits in two.

🤖 Generated with Claude Code

Because:
 - On /pair/authority/scan_qr the "Get help scanning" link had no width
   limit, so long translations such as French ran past the phone bezel.

This commit:
 - Caps the link at 46% of the artwork so long strings wrap onto a second
   line inside the phone screen.

Closes #FXA-14486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant