Skip to content

refactor(ads-client): housekeeping - sort fields/methods, add UniFFI defaults, split docs, add Client in HttpCache#7316

Open
Almaju wants to merge 1 commit intomozilla:mainfrom
Almaju:ac-94-ads-client-refactoring
Open

refactor(ads-client): housekeeping - sort fields/methods, add UniFFI defaults, split docs, add Client in HttpCache#7316
Almaju wants to merge 1 commit intomozilla:mainfrom
Almaju:ac-94-ads-client-refactoring

Conversation

@Almaju
Copy link
Copy Markdown
Contributor

@Almaju Almaju commented Apr 9, 2026

  • Sort struct fields alphabetically (HttpCache)
  • Sort methods: constructors → pub (alpha) → private (alpha) in HttpCache, AdsClient, MARSClient
  • Add #[uniffi(default = None)] to optional FFI fields for better consumer ergonomics (iab_content, cache config fields, ttl_seconds)
  • Replace manual Default impl with #[derive(Default)] (clippy)
  • Split usage.md into per-language files (JavaScript, Kotlin, Swift) with only consumer-facing examples; update README links
  • Add viaduct::Client in HttpCache to make it compatible with future OHTTP impl

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@Almaju Almaju changed the title refactor(ads-client): housekeeping — sort fields/methods, add UniFFI defaults, split docs refactor(ads-client): housekeeping - sort fields/methods, add UniFFI defaults, split docs Apr 9, 2026
@Almaju Almaju changed the title refactor(ads-client): housekeeping - sort fields/methods, add UniFFI defaults, split docs refactor(ads-client): housekeeping - sort fields/methods, add UniFFI defaults, split docs, add Client in HttpCache Apr 9, 2026
@Almaju Almaju force-pushed the ac-94-ads-client-refactoring branch 5 times, most recently from d49b8e6 to 31bdf94 Compare April 9, 2026 21:34
@Almaju Almaju marked this pull request as ready for review April 9, 2026 21:34
…defaults, split docs

- Sort struct fields alphabetically (HttpCache)
- Sort methods: constructors → pub (alpha) → private (alpha) in
  HttpCache, AdsClient, MARSClient
- Add #[uniffi(default = None)] to optional FFI fields for better
  consumer ergonomics (iab_content, cache config fields, ttl_seconds)
- Replace manual Default impl with #[derive(Default)] (clippy)
- Split usage.md into per-language files (JavaScript, Kotlin, Swift)
  with only consumer-facing examples; update README links
@Almaju Almaju force-pushed the ac-94-ads-client-refactoring branch from 31bdf94 to f7fe7f4 Compare April 9, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant