feat(ads-client): add OHTTP support (AC-94)#7315
Draft
Almaju wants to merge 1 commit intomozilla:mainfrom
Draft
Conversation
5654d59 to
b9cd744
Compare
e1f3556 to
0e85300
Compare
cf209d8 to
2139dae
Compare
…lient - ohttp_client is always initialized (no longer Option<Client>) - fetch_ads, record_click, record_impression, report_ad all take ohttp: bool to select direct vs OHTTP transport per request - HttpCache no longer owns a Client; send_with_policy/fetch_and_cache take &Client as first arg, removing the need for set_client - enable_ohttp/disable_ohttp now only manage preflight (geo/UA headers) - FFI methods default ohttp to false for backward compatibility
2139dae to
e3f7000
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ohttp: boolfield toMozAdsRequestOptionsand newMozAdsCallbackOptions { ohttp: bool }to opt individual requests into OHTTP routingrequest_tile_ads,request_image_ads,request_spoc_ads,record_impression,record_click,report_adoptionsparameters use UniFFI defaults so existing callers require no changesOHTTP_CHANNEL_IDfromhttp_cacheintoclient— http_cache is now generic and has no ads-client knowledge#[uniffi(default = None/false)]to optional fields acrossMozAdsPlacementRequest,MozAdsCacheConfig,MozAdsRequestCachePolicyfor better ergonomics in consumer codedocs/usage.mdinto per-language files (usage-javascript.md,usage-kotlin.md,usage-swift.md) with correct language-specific examplesviaduct'sohttpfeature depends on NSS)test_contract_tile_ohttp_prodagainst production MARS over OHTTPPull Request checklist
[ci full]to the PR title.