Skip to content

Add SSDLC and SBOM Actions#25185

Open
diox wants to merge 9 commits into
masterfrom
add-ssdlc-actions
Open

Add SSDLC and SBOM Actions#25185
diox wants to merge 9 commits into
masterfrom
add-ssdlc-actions

Conversation

@diox

@diox diox commented Jul 23, 2026

Copy link
Copy Markdown
Member

Part of https://mozilla-hub.atlassian.net/browse/AMOENG-2638 and https://mozilla-hub.atlassian.net/browse/AMOENG-2637

Since the SSDLC action includes zizmor I've removed our own integration.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@diox
diox requested review from a team and nothingrandom and removed request for a team July 23, 2026 15:27
Comment thread .github/workflows/sbom.yml

@nothingrandom nothingrandom left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some queries, but otherwise fine

permissions: {}

jobs:
code-security-analysis:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to cause a bunch of future issues in the future when we update a file? Is there a way to see any outstanding issues with existing code?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should already pass the checks (this can be seen by looking at the logs for each check in that PR) but once it's merged it will also appear in the security tab for the repos.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I spoke too soon, semgrep finds some errors. I'll fix them in a separate PR before merging this.

Comment thread src/olympia/api/jwt_auth.py Dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants