Add SSDLC and SBOM Actions#25185
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
nothingrandom
left a comment
There was a problem hiding this comment.
Some queries, but otherwise fine
| permissions: {} | ||
|
|
||
| jobs: | ||
| code-security-analysis: |
There was a problem hiding this comment.
Is this going to cause a bunch of future issues in the future when we update a file? Is there a way to see any outstanding issues with existing code?
There was a problem hiding this comment.
We should already pass the checks (this can be seen by looking at the logs for each check in that PR) but once it's merged it will also appear in the security tab for the repos.
There was a problem hiding this comment.
Actually I spoke too soon, semgrep finds some errors. I'll fix them in a separate PR before merging this.
Part of https://mozilla-hub.atlassian.net/browse/AMOENG-2638 and https://mozilla-hub.atlassian.net/browse/AMOENG-2637
Since the SSDLC action includes zizmor I've removed our own integration.