This repository was archived by the owner on Feb 29, 2020. It is now read-only.
Bug 1598876 - Fix intermittent link test failure#5390
Open
gvn wants to merge 3 commits intomozilla:masterfrom
Open
Bug 1598876 - Fix intermittent link test failure#5390gvn wants to merge 3 commits intomozilla:masterfrom
gvn wants to merge 3 commits intomozilla:masterfrom
Conversation
Mardak
suggested changes
Nov 28, 2019
Member
Mardak
left a comment
There was a problem hiding this comment.
The test was making sure top sites gets rendered as well as the link getting rendered, so this change makes it only test the latter. If the link is getting delayed, you can wrap the querySelector with await ContentTaskUtils.waitForCondition just like what's done for topSites.
Collaborator
|
I also wonder if we can instead of waiting and checking the text, just check for the href, and not the text content, thus it wouldn't need to be waiting for fluent. (we're not testing fluent anyway) thoughts? |
Collaborator
|
Was thinking about this more. I think maybe ideally we have a test layout for this, so we don't have fluent strings being used here at all. (assuming that's the issue, which I'm only about 80% sure of) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run
mach test discovery_renderand confirm exit code of 0. (Try this several times.)