Skip to content

Fix hiddenVideoControlsContextMenuTest UI test #4500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonalmeida merged 1 commit into from
Aug 24, 2026
+14 −5
Merged

Fix hiddenVideoControlsContextMenuTest UI test #4500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions app/src/androidTest/assets/pages/noControlsVideoMediaPage.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
<html>
<!DOCTYPE html>
<html lang="en">
<head>
<title>No_Controls_Video_Test_Page</title>
<meta name="viewport" content="width=device-width, initial-scale=1">
</head>
<body>
<p id="testContent">Page content: video player</p>
<body style="margin:0;display:flex;align-items:center;justify-content:center;height:100vh">
<video title="test_link_video" width="320" height="240">
<source src="../resources/mov_bbb.mp4" type="video/mp4">
Your browser does not support HTML video.
</video>

</body>
</html>
</html>
2 changes: 1 addition & 1 deletion app/src/androidTest/java/org/mozilla/reference/browser/ui/MediaPlaybackTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class MediaPlaybackTest {

navigationToolbar {}
.enterUrlAndEnterToBrowser(noControlsVideoTestPage.url) {
longClickMatchingText("test_link_video")
longClickVideoWithNoControls()
verifyNoControlsVideoContextMenuItems()
}
}
Expand Down
8 changes: 8 additions & 0 deletions app/src/androidTest/java/org/mozilla/reference/browser/ui/robots/BrowserRobot.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,14 @@ class BrowserRobot {
link.click(LONG_CLICK_DURATION)
}

fun longClickVideoWithNoControls() {
mDevice.waitForWindowUpdate(packageName, waitingTime)
mDevice.findObject(UiSelector().resourceId("$packageName:id/engineView")).waitForExists(waitingTime)
mDevice.waitForIdle()
val engineView = mDevice.findObject(By.res("$packageName:id/engineView"))
engineView.click(engineView.visibleCenter, LONG_CLICK_DURATION)
}

fun longClickAndCopyText(
expectedText: String,
selectAll: Boolean = false,
Expand Down