👾 Enable ALPN and support HTTP/1.1 in transport.rs#322
Closed
Rnbsov wants to merge 2 commits into
Closed
Conversation
Updated `transport.rs` to enable `ALPN` for protocol negotiation and support both `HTTP/1.1` and `HTTP/2`.
Member
|
I'm not sure what this change does since gRPC only works over http/2. Can you add more detail on what this is doing, exactly? |
Member
|
Closing this for now, to keep things tidy, but can re-open if needed. |
Author
|
I'm using |
Author
|
@gschier more precisely, https://connectrpc.com/docs/node/server-plugins#protocol-support-in-express |
Member
|
I still don't understand @Rnbsov. Did you test that this change actually lets you interact with a connectRPC API successfully? The gRPC library that Yaak uses ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
transport.rsto enableALPNfor protocol negotiation and support bothHTTP/1.1andHTTP/2.closes: https://feedback.yaak.app/p/grpc-testing-over-http11