fix: refuse both-numeric names to match the registry policy - #17
Open
nivokvo wants to merge 1 commit into
Open
Conversation
parseRegistryName accepted '1.420' as a Moshpit name while the registry (moshpit-name) refuses it — several parsers read a two-part dotted number as an abbreviated IPv4 literal. The file's own header promises the same semantics as the reference implementation, and the comment on the label rule says matching the registry matters more than the rule itself; this branch diverged from both. Effect before the fix: with clearnet silent, '1.420' resolved to a parking page for a name the registry can never register.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16
parseRegistryNameaccepted1.420while the registry refuses it (IPv4-literal ambiguity). This port now applies the same refusal, per its own header promise of same semantics and the label-rule comment that matching the registry matters more than the rule itself.1.420,420.187→ nullblue.420,420.blue→ still valid