Repository navigation
fix(work): collect a passing change when .gitignore ignores the linked node_modules - #581
Merged
Merged
Conversation
…d node_modules Seen on the fleet sweep: in repos whose .gitignore says node_modules (no trailing slash) the symlink is ignored, and naming it in an exclude pathspec made git refuse the whole add. The verify had passed, the run called it a failed verify and retried twice, then filed it in the inbox. Collect with a plain git add -A, then git rm --cached the links. And a pass whose change cannot be collected goes to the inbox at once with the real reason and its tree kept, instead of being retried. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan0 finding(s) in the 2 file(s) this pull request changes. Nothing in the files this pull request changes. 106 pre-existing finding(s) elsewhere in the repository — **HIGH/CRITICAL**: 8 | **MEDIUM**: 87 | **LOW**: 11Not introduced by this pull request. The full set is in the Security tab.
…and 86 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen on the fleet sweep (
fleet-real, 9 tasks): two tasks whose verify passed went to the inbox asgit add failed: The following paths are ignored by one of your .gitignore files: node_modules, after being retried twice as "failed verify (exit 0)".In a repo whose
.gitignoresaysnode_moduleswithout a trailing slash, the linkednode_modulessymlink is ignored, and naming an ignored path ingit add(the:(exclude)pathspec) makes git refuse the whole add.git add -A, thengit rm -r --cached --ignore-unmatchthe linked paths.Tests: two regressions in
test/work.test.mjs(ignored-link repo collects in one attempt; a collect failure goes straight to the inbox); work 19/19.🤖 Generated with Claude Code