Fix REST API for popstore.ProductServices.get#SortedProductList#65
Open
acetousk wants to merge 1 commit intomoqui:masterfrom
Open
Fix REST API for popstore.ProductServices.get#SortedProductList#65acetousk wants to merge 1 commit intomoqui:masterfrom
acetousk wants to merge 1 commit intomoqui:masterfrom
Conversation
Member
|
What is the scenario this is meant to accommodate? Doing a query on ProductCategoryMemberProduct with no productCategoryId would in effect find all products that are in any category. It might be best if this treated the no category scenario the same as no products in the category (ie if a category is not specified then no products found). On a side note, the same effect as this patch can be done with the ignore-if-empty="true" attribute on the econdition element, but either way I don't think this is the business logic we want here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per: https://forum.moqui.org/t/is-there-a-api-in-popreststore-which-can-get-all-the-products/155/3