changed server rendered root d# to d to allow google analytics to function for server rendered screens#60
Open
acetousk wants to merge 1 commit intomoqui:masterfrom
Open
changed server rendered root d# to d to allow google analytics to function for server rendered screens#60acetousk wants to merge 1 commit intomoqui:masterfrom
acetousk wants to merge 1 commit intomoqui:masterfrom
Conversation
…ction for server rendered screens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
I was notified that some implementations of google analytics didn't work for the server rendered screens (specifically the checkout screen).
Possible Causes:
Possible Solutions:
Explanation:
I tried removing the # when trying to render using the vue-router and it made it so that the url is not https://.../d#/checkout/ but instead https://.../d/checkout#/. I didn't notice any functionality changes, and don't imagine that there would be functionality related to having a # in the url, but to test whether this is the problem. This would be a good way to test if this is the correct problem for getting google analytics to work.
Possible Drawbacks:
The url for server rendered screens is changed from https://.../d#/checkout/ to https://.../d/checkout#/. This shouldn't change functionality, but it might.