Closed
Conversation
- A root node listening on port 4443. - A leaf node listening on port 4444. - A leaf node listening on port 4445. The two leaf nodes will connect to the root node using the `dev/root.jwt` token.
jhiatt-verkada
commented
Feb 6, 2026
|
|
||
| /// The expiration time of the token as a unix timestamp. | ||
| #[serde(rename = "exp")] | ||
| #[serde(rename = "exp", skip_serializing_if = "Option::is_none")] |
Contributor
Author
There was a problem hiding this comment.
Not sure if anything changed but the token validation code was choking on tokens with "exp": null.
| let url = match token.is_empty() { | ||
| true => Url::parse(&format!("https://{node}/"))?, | ||
| false => Url::parse(&format!("https://{node}/?jwt={token}"))?, | ||
| false => Url::parse(&format!("https://{node}/?jwt={token}&node={cluster_node}"))?, |
Contributor
Author
There was a problem hiding this comment.
This should be properly escaped
| // Announce ourselves as an origin to the root node. | ||
| // This goes into primary so it gets shared with other nodes via run_remote_once. | ||
| if let Some(myself) = self.config.node.as_ref() { | ||
| if false && let Some(myself) = self.config.node.as_ref() { |
Contributor
Author
There was a problem hiding this comment.
Hack to disable existing publish (should just be deleted)
| .accept() | ||
| .await?; | ||
|
|
||
| let _node_announce = if let Some(cluster_node) = cluster_node |
Contributor
Author
There was a problem hiding this comment.
Gets dropped when session ends -> node is unpublished
Collaborator
|
#923 is my version of this, untested |
Collaborator
|
replaced by #923 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not intended to be mergeable but serves as a proof-of-concept where all cluster node announcements are published on the root node. The cluster leaves specify a query parameter indicating what hostname to publish.