Skip to content

fix(js/net): serialize subscription updates with group pops - #2820

Draft
kixelated wants to merge 1 commit into
devfrom
codex/js-publisher-control-loop
Draft

fix(js/net): serialize subscription updates with group pops#2820
kixelated wants to merge 1 commit into
devfrom
codex/js-publisher-control-loop

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

Root cause

recvGroup() removed a buffered group synchronously, but the publisher snapshotted mutable frame bounds in a later promise job. A buffered SUBSCRIBE_UPDATE could run between those steps and serve the group under bounds it was never taken under.

Public API changes

None. The synchronous group receive and readiness hooks are package-internal.

Test plan

  • nix develop --command just check
  • nix develop --command just test
  • focused publisher and track tests covering control-before-pop and pop-before-control ordering

Closes #2808.

(Written by GPT-5)

Co-Authored-By: GPT-5 <noreply@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant