(DON'T MERGE) refactor(net): replace routes instead of splicing - #2723
Draft
kixelated wants to merge 1 commit into
Draft
(DON'T MERGE) refactor(net): replace routes instead of splicing#2723kixelated wants to merge 1 commit into
kixelated wants to merge 1 commit into
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Collaborator
Author
|
I made this as an emergency break glass PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The root cause was that route selection mutated a synthetic broadcast underneath live subscribers. Preserving subscription state across independently owned sources required frame-precise resume bookkeeping and several handover paths, which repeatedly produced lifecycle and routing bugs. Source-bound subscriptions make replacement explicit and leave resubscription policy with the consumer.
Public API changes
Test plan
nix develop --command just fixnix develop --command cargo nextest run -p moq-net(712 passed)moq-relayGOAWAY replacement testsnix develop --command just drafts checknix develop --command just checknix develop --command just test smoke-full(21 publisher/subscriber combinations passed)git diff --check(Written by GPT-5)