Added marshalling to struct...#525
Conversation
There was a problem hiding this comment.
What @tritao had in mind was to use IsPOD instead of IsValueType. So you'd best change it to just:
return @class.IsPOD.
|
Marshalling some classes as structs is OK, this is what @tritao 's idea is: marshal types based on their usage, not on the key-word which means almost nothing in C++. The error you get, however, is indeed a problem. What exactly is it? |
|
@ddobrev The code marshals a class which was intended to be a Ref type as I had written it for testing a fix when CS_OUT was applied to a ref type argument. |
d45e2da to
dd941d9
Compare
|
@ddobrev Adding this pass to generator didn't seem to be good. Because of two main reasons: |
|
Hello @genuinelucifer . Please accept my apologies for this huge delay. I've been really busy with Qt#, I am almost ready to build GUI examples with it and it needs a last effort. Meanwhile please proceed with the task about delegates, it's more important than this one anyway. |
|
@ddobrev That's great! :) I had a look into Qt# and it really seems that you have put much much effort into it. Best of Luck! I'm actually unable to proceed with the delegates task because I actually don't know much about them and actually couldn't figure out how to do that. I will post my real problems on that issue soon. |
|
@genuinelucifer I am glad you have started thinking about the task. Feel free to ask any questions. I still don't have time to review this one but I have more than enough for questions. |
ad9811b to
beabb82
Compare
ff30267 to
e6a74df
Compare
|
Hey @ddobrev we should review this soon. |
b7efc4e to
c4c2ef2
Compare
a2a14c5 to
f197aad
Compare
99934be to
6a0069f
Compare
09fd87d to
aabe740
Compare
da1b8ba to
1f25e02
Compare
9fc81b8 to
cbafb55
Compare
e95c3f8 to
5dac663
Compare
4f3ca17 to
6ed05c2
Compare
Mostly done... But, one other error is exposed due to this. And moreover it now also marshals few C++ classes to C# struct.
Was that intended while using
@class.IsPOD@tritao @ddobrevAlso, I did not add the check for is declared as struct this time.