feat(lang): add Punjabi (Gurmukhi) language (By: Sahajbir Brar) - #8393
Open
polyhistor2024-cyber wants to merge 4 commits into
Open
feat(lang): add Punjabi (Gurmukhi) language (By: Sahajbir Brar)#8393polyhistor2024-cyber wants to merge 4 commits into
polyhistor2024-cyber wants to merge 4 commits into
Conversation
Contributor
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and also include the author name at the end inside parenthesis. It looks like your proposed title needs to be adjusted. Details: A correct version would look something like: feat: add new feature (@github_username) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the Punjabi Language and its Gurmukhi script. The parent group of the Punjabi language is only called Punjab (not Punjabi_gurmukhi), so Shahmukhi users can include the Shahmukhi script within said parent language.
I have given the internal name Punjabi_gurmukhi.
For those whishing to build on, I'd reccomend reaching 1k words, creating a Shahmukhi script option, and adding quotes for the language.