Skip to content

fix(words-filter): account for British spelling (@NiketGirdhar22)#8243

Open
NiketGirdhar22 wants to merge 1 commit into
monkeytypegame:masterfrom
NiketGirdhar22:fix/word-filter-british-english
Open

fix(words-filter): account for British spelling (@NiketGirdhar22)#8243
NiketGirdhar22 wants to merge 1 commit into
monkeytypegame:masterfrom
NiketGirdhar22:fix/word-filter-british-english

Conversation

@NiketGirdhar22

@NiketGirdhar22 NiketGirdhar22 commented Jul 18, 2026

Copy link
Copy Markdown

Description

The word filter previously evaluated the original word-list spelling before British English substitutions were applied. With English 1k+ languages, this could make filter presets behave incorrectly because the spelling used for filtering differed from the spelling shown during the test.
This change applies the existing British English conversion while evaluating word-filter rules. It still stores the original words in the custom word list, leaving final spelling conversion to the normal word-generation flow. The conversion helper is now synchronous because it only performs local string lookups.
Regression tests cover British English being enabled or disabled, preserving original words, and applying length filters after spelling conversion.

Checks

  • Confirmed this does not add quotes, a language, a theme, a layout, or a font.
  • Verified the related issue is still open and has no competing open PR.
  • Used a Conventional Commits title with the contributor username.
  • Built shared packages.
  • Passed the focused British English and word-filter tests (14 tests).
  • Passed formatting, type-aware linting, type checking, and the pre-commit hook.

Closes #6097

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jul 18, 2026
@NiketGirdhar22
NiketGirdhar22 marked this pull request as ready for review July 18, 2026 05:52
@github-actions github-actions Bot added the waiting for review Pull requests that require a review before continuing label Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff waiting for review Pull requests that require a review before continuing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Words filter presets does not account for different spellings when using English 1k+

2 participants