fix(words-filter): account for British spelling (@NiketGirdhar22)#8243
Open
NiketGirdhar22 wants to merge 1 commit into
Open
fix(words-filter): account for British spelling (@NiketGirdhar22)#8243NiketGirdhar22 wants to merge 1 commit into
NiketGirdhar22 wants to merge 1 commit into
Conversation
NiketGirdhar22
marked this pull request as ready for review
July 18, 2026 05:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The word filter previously evaluated the original word-list spelling before British English substitutions were applied. With English 1k+ languages, this could make filter presets behave incorrectly because the spelling used for filtering differed from the spelling shown during the test.
This change applies the existing British English conversion while evaluating word-filter rules. It still stores the original words in the custom word list, leaving final spelling conversion to the normal word-generation flow. The conversion helper is now synchronous because it only performs local string lookups.
Regression tests cover British English being enabled or disabled, preserving original words, and applying length filters after spelling conversion.
Checks
Closes #6097