fix(account): fix "load more" button state for filtered results (@d1rshan)#8020
Open
d1rshan wants to merge 4 commits into
Open
fix(account): fix "load more" button state for filtered results (@d1rshan)#8020d1rshan wants to merge 4 commits into
d1rshan wants to merge 4 commits into
Conversation
github-actions
Bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Replaces the use of getResultsSize() with a direct length check on the loaded results data to determine whether the "load more" button should be disabled on the account page.
Changes:
- Removed the
getResultsSizeimport from../../../collections/results. - Updated the "load more" button disabled condition to compare
resultsQueryData().lengthagainstlimit().
github-actions
Bot
removed
the
waiting for review
d1rshan
changed the title
github-actions
Bot
added
the
waiting for review
fehmer
reviewed
May 28, 2026
github-actions
Bot
removed
the
waiting for review
fehmer
reviewed
May 28, 2026
Member
|
hi @d1rshan , nice solution. Few comments on the pr |
fehmer
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"load more" button used
getResultsSize()(unfiltered total) to decide if more results exist. With active filters this always showed the button as enabled.Fix
limit + 1filtered resultslimit