Skip to content

DRIVERS-3162 Add test for SRV hostname validation#2823

Closed
aclark4life wants to merge 2 commits into
masterfrom
DRIVERS-3162
Closed

DRIVERS-3162 Add test for SRV hostname validation#2823
aclark4life wants to merge 2 commits into
masterfrom
DRIVERS-3162

Conversation

@aclark4life

Copy link
Copy Markdown
Contributor
  • Fix test name to reflect three parts

DRIVERS-3162

Changes in this PR

  • Add test for SRV hostnames with three or more parts

Test Plan

  • New spec test

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is there test coverage?
  • Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

@aclark4life aclark4life requested a review from a team as a code owner May 27, 2026 20:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov-commenter

codecov-commenter commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@aclark4life aclark4life force-pushed the DRIVERS-3162 branch 2 times, most recently from 3d1c769 to 6b68a81 Compare June 1, 2026 15:43
@aclark4life aclark4life requested a review from Copilot June 1, 2026 15:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@aclark4life aclark4life force-pushed the DRIVERS-3162 branch 2 times, most recently from ad62279 to 45bb9c9 Compare June 4, 2026 17:27
@NoahStapp

Copy link
Copy Markdown
Contributor

@aclark4life is this ready for review? I see a lot of test failures. This PR should also link to PYTHON-5327 and not the top-level DRIVERS ticket.

@aclark4life

Copy link
Copy Markdown
Contributor Author

@aclark4life is this ready for review? I see a lot of test failures. This PR should also link to PYTHON-5327 and not the top-level DRIVERS ticket.

Waiting on https://jira.mongodb.org/browse/DEVPROD-34211

@NoahStapp

NoahStapp commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@aclark4life is this ready for review? I see a lot of test failures. This PR should also link to PYTHON-5327 and not the top-level DRIVERS ticket.

Waiting on https://jira.mongodb.org/browse/DEVPROD-34211

Can you mark it as draft then and update the ticket to be blocked on that DEVPROD ticket?

@aclark4life aclark4life marked this pull request as draft June 9, 2026 14:42
@aclark4life

Copy link
Copy Markdown
Contributor Author

Superseded by #2863

@aclark4life aclark4life closed this Jun 9, 2026
@aclark4life aclark4life deleted the DRIVERS-3162 branch June 9, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants