refactor(ci): replace shell=True and awk pipes with native Python #2671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces dangerous shell=True calls in resync-all-specs.py with safer list-based subprocess executions. It also replaces complex shell pipes with native Python logic to improve security and cross-platform reliability.
|
Assigned |
Applied black formatting and fixed ruff issues (noqa placements, type hints, and pathlib migration) to pass CI/CD.
Adjusted noqa placements to satisfy Ruff 0.1.3 and applied consistent formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates potential command injection risks and system dependency issues in the Evergreen spec resync script.
Modifications:
apply_patches: Switched fromshell=Trueto list-basedsubprocess.run. Implemented Python'sglobfor file expansion instead of relying on the shell's wildcard expansion.write_summarylogic: Replaced the fragilegit diff | awk | sort | uniqshell pipeline with native Python string manipulation and sets. This removes the implicit dependency onawkand improves cross-platform reliability.The script now executes git commands directly without spawning intermediate shells.